fix: fix Series construction with data as an iterator #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
requested changes
Sep 23, 2025
There was a problem hiding this comment.
Hi @terencehonles , thank you for the proposal. Having checked the Pandas documentation, and it seems that data can indeed be an Iterator.
Comment on lines
+159
to
+163
| check( | ||
| assert_type(pd.Series(iter([1.0])), "pd.Series[float]"), | ||
| pd.Series, | ||
| float, | ||
| ) |
There was a problem hiding this comment.
Several __new__'s have been retyped, but only one test has been added. Please complete the new tests. Alternatively, you can split the old test function into two.
| def __new__( | ||
| cls, | ||
| data: Sequence[_str], | ||
| data: Iterator[_str], |
There was a problem hiding this comment.
Iterator[_str] can be ambiguous, because _str is an Iterable in its own right. However, I don't have more insights how to improve this.
There was a problem hiding this comment.
You can use Iterator[SequenceNotStr[_str]]
|
Hi @terencehonles , would you be able to follow up on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value